[Intel-gfx] [PATCH] drm/i915: Update kerneldoc for intel_wm_need_update()

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Dec 31 15:05:43 UTC 2018


On 31/12/2018 14:35, Chris Wilson wrote:
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Function parameter or member 'cur' not described in 'intel_wm_need_update'
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Function parameter or member 'new' not described in 'intel_wm_need_update'
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Excess function parameter 'plane' description in 'intel_wm_need_update'
> drivers/gpu/drm/i915/intel_display.c:10708: warning: Excess function parameter 'state' description in 'intel_wm_need_update'
> 
> References: cd1d3ee90e5e ("drm/i915: Use intel_ types more consistently for watermark code (v2)")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>   drivers/gpu/drm/i915/intel_display.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index f0a468cc0912..57fd5613c395 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10695,8 +10695,8 @@ static void intel_crtc_destroy(struct drm_crtc *crtc)
>   
>   /**
>    * intel_wm_need_update - Check whether watermarks need updating
> - * @plane: drm plane
> - * @state: new plane state
> + * @cur: current plane state
> + * @new: new plane state
>    *
>    * Check current plane state versus the new one to determine whether
>    * watermarks need to be recalculated.
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list