[Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup(&data) for psr_basic

Petri Latvala petri.latvala at intel.com
Thu Jan 4 12:11:06 UTC 2018


On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> The "*ERROR* Potential atomic update failure on pipe A"
> started to occure on some BAT machines with IGT_4063.
> Looking at the dmesgs the ERROR print come when the
> subtest is exiting. So, this is just a longshot to test if
> we may need to do the cleanup on this subtest as well.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> 
> Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 83a69f0b..7ee4c2f4 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
>  	igt_subtest("psr_basic") {
>  		setup_test_plane(&data);
>  		igt_assert(wait_psr_entry(&data));
> +		test_cleanup(&data);
>  	}


This looks correct indeed.


>  
>  	igt_subtest("psr_drrs") {


But the same is required here, isn't it?



-- 
Petri Latvala


More information about the Intel-gfx mailing list