[Intel-gfx] [CI v2 1/2] drm/i915/guc: Add uc_fini_wq in gem_init unwind path

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 10 14:03:45 UTC 2018


Quoting Sagar Arun Kamble (2018-01-10 12:54:16)
> While moving code around for solving lockdep issue for GuC log relay,
> spotted that uc_fini_wq is not being called in failure path in gem_init.
> Missed in the below commit. Add it.
> 
> v2: Removed GEM_BUG_ON(!HAS_GUC()) from intel_uc_fini_wq as init happens
> only based on enable_guc module parameter and does not consider has_guc
> capability. (Michal)
> 
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> Fixes: 3176ff49bc3e ("drm/i915/guc: Move GuC workqueue allocations outside of the mutex")
> Cc: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

And pushed. Thanks for the patch and review,
-Chris


More information about the Intel-gfx mailing list