[Intel-gfx] [PATCH i-g-t 2/6] Makefile.meson: use $(error ...) for errors

[Petri Latvala]

On Tue, Oct 24, 2017 at 12:52:52PM +0300, Jani Nikula wrote:
> This is the usual way of flagging fatal errors in Makefiles, and gives
> you the error exit code too.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>


Regardless of where this change is done (meson.sh output or
Makefile.meson, see reply to patch 1),

Reviewed-by: Petri Latvala <petri.latvala at intel.com>




> ---
>  Makefile.meson | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile.meson b/Makefile.meson
> index 2ed642bdab37..6955e6a9a694 100644
> --- a/Makefile.meson
> +++ b/Makefile.meson
> @@ -24,10 +24,10 @@ reconfigure: build/build.ninja
>  	ninja -C build reconfigure
>  
>  check distcheck dist distclean:
> -	echo "This is the meson wrapper, not automake" && false
> +	$(error This is the meson wrapper, not automake)
>  
>  install uninstall:
> -	echo "meson install support not yet completed" && false
> +	$(error meson install support not yet completed)
>  
>  docs:
> -	echo "meson gtkdoc support not yet completed" && false
> +	$(error meson gtkdoc support not yet completed)
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx