[Intel-gfx] [PATCH 6/8] drm/i915/icp: Add backlight Support for ICP

[Ausmus, James]

On Fri, Jan 19, 2018 at 10:48 AM, Paulo Zanoni <paulo.r.zanoni at intel.com>
wrote:
>
> From: Anusha Srivatsa <anusha.srivatsa at intel.com>
>
> ICP has two backlight controllers - similar to previous platforms like
> BXT -, but we only use one controller for now, so we can just reuse
> the CNP code.
>
> v2: Remove the usage of ICP_SECOND_PPS_BACKLIGHT register.(Jani)
> Reuse CNP code since it is very similar.(Ville)
> v3 (from Paulo): Rebase.
> v4 (from Paulo): adjust commit message (James) and comment (Rodrigo).
>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Ville Syrjala <ville.syrjala at linux.intel.com>
> Cc: James Ausmus <james.ausmus at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

Looks good, thanks!

Acked-by: James Ausmus <james.ausmus at intel.com>


>
> ---
>  drivers/gpu/drm/i915/intel_panel.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c
b/drivers/gpu/drm/i915/intel_panel.c
> index fa6831f8c004..e702a6487aa9 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1719,9 +1719,9 @@ cnp_setup_backlight(struct intel_connector
*connector, enum pipe unused)
>         u32 pwm_ctl, val;
>
>         /*
> -        * CNP has the BXT implementation of backlight, but with only
> -        * one controller. Future platforms could have multiple
controllers
> -        * so let's make this extensible and prepared for the future.
> +        * CNP has the BXT implementation of backlight, but with only one
> +        * controller. TODO: ICP has multiple controllers but we only use
> +        * controller 0 for now.
>          */
>         panel->backlight.controller = 0;
>
> @@ -1865,7 +1865,7 @@ intel_panel_init_backlight_funcs(struct intel_panel
*panel)
>                 panel->backlight.set = bxt_set_backlight;
>                 panel->backlight.get = bxt_get_backlight;
>                 panel->backlight.hz_to_pwm = bxt_hz_to_pwm;
> -       } else if (HAS_PCH_CNP(dev_priv)) {
> +       } else if (HAS_PCH_CNP(dev_priv) || HAS_PCH_ICP(dev_priv)) {
>                 panel->backlight.setup = cnp_setup_backlight;
>                 panel->backlight.enable = cnp_enable_backlight;
>                 panel->backlight.disable = cnp_disable_backlight;
> --
> 2.14.3
>



--


James Ausmus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20180119/fb932de1/attachment.html>