[Intel-gfx] [PATCH v3 5/6] drm/i915/guc: Fix comments style in intel_guc_log.c

Michal Wajdeczko michal.wajdeczko at intel.com
Wed Jan 24 09:50:48 UTC 2018


On Wed, 24 Jan 2018 10:49:02 +0100, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Sagar Arun Kamble (2018-01-24 04:09:11)
>> Use consistent multi-line comment style as per guideline.
>>
>> Suggested-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> ---
>>  drivers/gpu/drm/i915/intel_guc_log.c | 49  
>> +++++++++++++++++++++++-------------
>>  1 file changed, 32 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_guc_log.c  
>> b/drivers/gpu/drm/i915/intel_guc_log.c
>> index 27eb545..7c6c41b 100644
>> --- a/drivers/gpu/drm/i915/intel_guc_log.c
>> +++ b/drivers/gpu/drm/i915/intel_guc_log.c
>> @@ -30,7 +30,7 @@
>>
>>  static void guc_log_capture_logs(struct intel_guc *guc);
>>
>> -/**
>> +/*
>>   * DOC: GuC firmware log
>>   *
>>   * Firmware log is enabled by setting i915.guc_log_level to the  
>> positive level.
>
> The double ** here indicates a kerneldoc. So this one is correct.

The one that is wrong is in guc_log_runtime_destroy()
as it ends with **/

Michal


More information about the Intel-gfx mailing list