[Intel-gfx] [PATCH] drm/i915: Remove Firmware URL.

[Srivatsa, Anusha]

>-----Original Message-----
>From: Vivi, Rodrigo
>Sent: Friday, January 26, 2018 10:22 AM
>To: intel-gfx at lists.freedesktop.org
>Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Srivatsa, Anusha
><anusha.srivatsa at intel.com>
>Subject: [PATCH] drm/i915: Remove Firmware URL.
>
>The right place for the firmware is linux-firmware.git.
>We shouldn't advertise anywhere to users to start downloading firmware blobs
>manually.
>
>Also it seems that 01.org page is outdated and it doesn't contain DMC 1.27 for
>SKL, for instance. Probably other firmware releases are missing there, while they
>are part of the official linux-firmware.git.
>
>So, let's stop advertising that place here.
>But also let's work in parallel to kill that page for good and maybe with a message
>explaining to users that they don't need to install manually, but rely on their
>distros for getting linux-firmware package updates.
>
>Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
Thanks for this much needed patch.

Reviewed-by: Anusha Srivatsa<anusha.srivatsa at intel.com>
>---
> drivers/gpu/drm/i915/intel_csr.c   | 2 --
> drivers/gpu/drm/i915/intel_uc_fw.c | 2 --  drivers/gpu/drm/i915/intel_uc_fw.h |
>3 ---
> 3 files changed, 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>index 41e6c75a7f3c..05761ffbf2ec 100644
>--- a/drivers/gpu/drm/i915/intel_csr.c
>+++ b/drivers/gpu/drm/i915/intel_csr.c
>@@ -429,8 +429,6 @@ static void csr_load_work_fn(struct work_struct *work)
> 			   "Failed to load DMC firmware %s."
> 			   " Disabling runtime power management.\n",
> 			   csr->fw_path);
>-		dev_notice(dev_priv->drm.dev, "DMC firmware homepage: %s",
>-			   INTEL_UC_FIRMWARE_URL);
> 	}
>
> 	release_firmware(fw);
>diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c
>b/drivers/gpu/drm/i915/intel_uc_fw.c
>index 784eff9cdfc8..f2c4ddb4b91d 100644
>--- a/drivers/gpu/drm/i915/intel_uc_fw.c
>+++ b/drivers/gpu/drm/i915/intel_uc_fw.c
>@@ -189,8 +189,6 @@ void intel_uc_fw_fetch(struct drm_i915_private
>*dev_priv,
>
> 	DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
> 		 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
>-	DRM_INFO("%s: Firmware can be downloaded from %s\n",
>-		 intel_uc_fw_type_repr(uc_fw->type),
>INTEL_UC_FIRMWARE_URL);
>
> 	release_firmware(fw);		/* OK even if fw is NULL */
> }
>diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h
>b/drivers/gpu/drm/i915/intel_uc_fw.h
>index d5fd4609c785..ee40852f2250 100644
>--- a/drivers/gpu/drm/i915/intel_uc_fw.h
>+++ b/drivers/gpu/drm/i915/intel_uc_fw.h
>@@ -29,9 +29,6 @@ struct drm_printer;
> struct drm_i915_private;
> struct i915_vma;
>
>-/* Home of GuC, HuC and DMC firmwares */ -#define
>INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware"
>-
> enum intel_uc_fw_status {
> 	INTEL_UC_FIRMWARE_FAIL = -1,
> 	INTEL_UC_FIRMWARE_NONE = 0,
>--
>2.13.6