[Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Allow preempt-client to be NULL

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 31 11:34:22 UTC 2018


Quoting Mika Kuoppala (2018-01-31 11:31:09)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > In the next patch, we may only conditionally allocate the preempt-client
> > if there is a global preempt context and so we need to be prepared in
> > case the preempt-client itself is NULL.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michal Winiarski <michal.winiarski at intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_guc_submission.c | 27 +++++++++++++++++----------
> >  1 file changed, 17 insertions(+), 10 deletions(-)
> >
> 
> You need to prepare the debugfs to handle the null also.
> 
> Does our simple igt/debugfs test include reading through all the nodes
> it finds?

It does, but we don't actually end up with NULLs.
-Chris


More information about the Intel-gfx mailing list