[Intel-gfx] [PATCH 1/6] drm/i915: Refactor export_fence() after i915_vma_move_to_active()

Chris Wilson chris at chris-wilson.co.uk
Mon Jul 2 11:44:24 UTC 2018


Quoting Tvrtko Ursulin (2018-07-02 12:34:51)
> > @@ -1921,6 +1914,8 @@ void i915_vma_move_to_active(struct i915_vma *vma,
> >   
> >       if (flags & EXEC_OBJECT_NEEDS_FENCE)
> >               i915_gem_active_set(&vma->last_fence, rq);
> > +
> > +     export_fence(vma, rq, flags);
> 
> Don't care about new extra reservation object operations from the other 
> i915_move_to_active_callers?

No. Not filling the reservation_object is an underhand shortcut. It
should never be not correct to track the fences for an object. Doing it
in one place correctly, should prevent cheating.
-Chris


More information about the Intel-gfx mailing list