[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen11: Preempt-to-idle support in execlists. (rev5)

Patchwork patchwork at emeril.freedesktop.org
Fri Jul 6 16:08:03 UTC 2018


== Series Details ==

Series: drm/i915/gen11: Preempt-to-idle support in execlists. (rev5)
URL   : https://patchwork.freedesktop.org/series/40747/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
90f487fed124 drm/i915/gen11: Preempt-to-idle support in execlists.
-:141: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!execlists->ctrl_reg"
#141: FILE: drivers/gpu/drm/i915/intel_lrc.c:539:
+		GEM_BUG_ON(execlists->ctrl_reg == NULL);

-:210: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#210: FILE: drivers/gpu/drm/i915/intel_lrc.c:1045:
+		if ((status & GEN8_CTX_STATUS_IDLE_ACTIVE) &&
+		     (status & GEN11_CTX_STATUS_PREEMPT_IDLE)) {

-:211: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#211: FILE: drivers/gpu/drm/i915/intel_lrc.c:1046:
+		     (status & GEN11_CTX_STATUS_PREEMPT_IDLE)) {
+

-:244: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#244: FILE: drivers/gpu/drm/i915/intel_lrc.c:1075:
+		    buf[2*head + 1] == execlists->preempt_complete_status)) {
 		         ^

total: 0 errors, 0 warnings, 4 checks, 192 lines checked



More information about the Intel-gfx mailing list