[Intel-gfx] [PATCH 0/4] drm/i915/intel_dsi: Read back and use pclk set by the GOP

[Hans de Goede]

Hi,

On 07/06/2018 03:14 PM, Jani Nikula wrote:
> On Fri, 29 Jun 2018, Hans de Goede <hdegoede at redhat.com> wrote:
>> Hi,
>>
>> On 19-06-18 22:18, Hans de Goede wrote:
>>> Hi All,
>>>
>>> This patch-set is the result of the work I've been doing recently to
>>> give people a smooth "flickerfree" boot experience where the display
>>> keeps displaying the logo put there by the firmware until it smoothly
>>> fades into the Linux GUI (e.g. gdm).
>>>
>>> While testing this on some BYT/CHT devices I noticed the screen going
>>> black for 1 second or so, because the first modeset was not a fast
>>> modeset despite passing i915.fastboot=1 on the kernel commandline.
>>>
>>> This is caused by the GOP and the i915 code differing in what they
>>> think the DSI pclk should be. This patch-set fixes this by reading
>>> back the pclk set by the GOP and if it is reasonably close to the
>>> clk calculated by the i915 code, using the GOP set pclk.
>>
>> Ping? A review of this series would be appreciated.
> 
> Sorry, swamped, and I was hoping Ville would chime in. ;)
> 
> The first two patches are trivial, ack. But I'd really like to know what
> the GOP is doing, and why we're different. Not sure if that's possible.
> 
> I'm afraid after much bikeshedding there were some file and function
> renames, and no matter what this series needs a rebase. See [1]. Sorry
> about the extra effort this causes; I truly appreciate your efforts with
> the DSI code, and I regret I haven't given this series the love it
> needs.

No problem. I'll pick up those patches and do a rebase, I'm currently
travelling so I don't have access to hardware to test this for a couple of
days. I will post a rebased version when I'm back.

Regards,

Hans