[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with kernel.h: Add for_each_if() (rev3)

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 9 16:50:04 UTC 2018


== Series Details ==

Series: series starting with kernel.h: Add for_each_if() (rev3)
URL   : https://patchwork.freedesktop.org/series/46158/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
071b9999f8d2 kernel.h: Add for_each_if()
-:6: WARNING:TYPO_SPELLING: 'ambigious' may be misspelled - perhaps 'ambiguous'?
#6: 
To avoid compilers complainig about ambigious else blocks when putting

-:79: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#79: FILE: include/linux/kernel.h:75:
+#define for_each_if(condition) if (!(condition)) {} else

total: 1 errors, 1 warnings, 0 checks, 16 lines checked
880b8b6d2995 blk: use for_each_if
-:28: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#28: FILE: include/linux/blk-cgroup.h:385:
+		for_each_if (((d_blkg) = __blkg_lookup(css_to_blkcg(pos_css), \

-:37: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#37: FILE: include/linux/blk-cgroup.h:400:
+		for_each_if (((d_blkg) = __blkg_lookup(css_to_blkcg(pos_css), \

total: 0 errors, 2 warnings, 0 checks, 16 lines checked
59429a9a04e8 cgroup: use for_each_if
-:26: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#26: FILE: include/linux/cgroup.h:290:
+		for_each_if ((leader) == (leader)->group_leader)

total: 0 errors, 1 warnings, 0 checks, 10 lines checked
c88bc20d1d7d cpufreq: use for_each_if
-:25: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#25: FILE: include/linux/cpufreq.h:652:
+		for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)

-:36: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#36: FILE: include/linux/cpufreq.h:664:
+		for_each_if (pos->frequency != CPUFREQ_ENTRY_INVALID)

total: 0 errors, 2 warnings, 0 checks, 20 lines checked
51bae47c38d6 dmar: Use for_each_If
-:20: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#20: FILE: include/linux/dmar.h:88:
+		for_each_if (!drhd->ignored)

-:25: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#25: FILE: include/linux/dmar.h:92:
+		for_each_if ((i=drhd->iommu, !drhd->ignored))

-:25: ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#25: FILE: include/linux/dmar.h:92:
+		for_each_if ((i=drhd->iommu, !drhd->ignored))
 		               ^

-:30: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#30: FILE: include/linux/dmar.h:96:
+		for_each_if ((i=drhd->iommu, true))

-:30: ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#30: FILE: include/linux/dmar.h:96:
+		for_each_if ((i=drhd->iommu, true))
 		               ^

-:40: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#40: FILE: include/linux/dmar.h:112:
+		for_each_if (d)

total: 2 errors, 4 warnings, 0 checks, 27 lines checked
35ba59407076 mm: use for_each_if
-:33: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#33: FILE: include/linux/mmzone.h:943:
+		for_each_if (populated_zone(zone))

total: 0 errors, 1 warnings, 0 checks, 10 lines checked
58b3d01c8b09 ide: use for_each_if
-:6: WARNING:TYPO_SPELLING: 'ambigious' may be misspelled - perhaps 'ambiguous'?
#6: 
Avoids complaints from gcc about ambigious else clauses. Not that any

-:22: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#22: FILE: include/linux/ide.h:1604:
+		for_each_if ((dev)->dev_flags & IDE_DFLAG_PRESENT)

total: 0 errors, 2 warnings, 0 checks, 8 lines checked
5c3d84d247de netdev: use for_each_if
-:21: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#21: FILE: include/linux/netdevice.h:2479:
+			for_each_if (netdev_master_upper_dev_get_rcu(slave) == (bond))

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
47bce1976e14 nubus: use for_each_if
-:21: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#21: FILE: include/linux/nubus.h:130:
+	for_each_func_rsrc(f) for_each_if (f->board == b)

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
ca22e9373f99 pci: use for_each_if
-:21: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#21: FILE: include/linux/pci.h:604:
+		for_each_if (pci_is_bridge(dev))

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
81dd933017d5 sched: use for_each_if in topology.h
-:21: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#21: FILE: include/linux/topology.h:43:
+		for_each_if (nr_cpus_node(node))

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
012e27898108 usb: use for_each_if
-:21: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#21: FILE: include/linux/usb.h:735:
+		for_each_if (child)

total: 0 errors, 1 warnings, 0 checks, 8 lines checked



More information about the Intel-gfx mailing list