[Intel-gfx] [PATCH 3/7] drm/i915: Convert fences to use a GGTT lock rather than struct_mutex

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 11 11:12:39 UTC 2018


Quoting Chris Wilson (2018-07-11 11:57:38)
> Quoting Daniel Vetter (2018-07-11 10:08:46)
> > I think the above change isn't correct, at least not yet at this stage:
> > All users of the userfault_list still use dev->struct_mutex, not vm.mutex.
> > I guess we could move that over to the ggtt.vm.mutex eventually, but this
> > patch doesn't do that.
> 
> It does, all those misplaced hunks are not so misplaced.

Since we have differing opinions on whether this is or is not
sufficiently guarding GGTT vs rpm, what test are we missing in CI to
conclusively indicate whether or not this is broken. As it stands, CI is
happy, and I don't have many machines where rpm works (since it requires
fw, sound drivers, etc).
-Chris


More information about the Intel-gfx mailing list