[Intel-gfx] [PATCH] drm/i915/selftests: Fixup GuC FW negative test

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 12 14:19:36 UTC 2018


Quoting Chris Wilson (2018-07-12 12:20:13)
> From: Michał Winiarski <michal.winiarski at intel.com>
> 
> Since:
> 0d4b78b3d2c0 ("drm/i915/guc: Assert we have the doorbell before setting it up")
> 
> We have asserts in GuC doorbell related functions, which is a good thing.
> Unfortunately, we were using those to check whether GuC FW is refusing
> to allocate invalid doorbell - which makes the test fail.
> Well, it would make the test WARN, except we fumbled cleanup ordering
> and eat the BUG_ON instead.
> Let's keep the asserts and use the internal implementation in the test.
> 
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michel Thierry <michel.thierry at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list