[Intel-gfx] [PATCH] drm/i915/guc: Skip cleaning up the doorbells on error-before-allocate

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 12 14:34:12 UTC 2018


Quoting Michał Winiarski (2018-07-12 14:12:48)
> On Thu, Jul 12, 2018 at 11:58:30AM +0100, Chris Wilson wrote:
> > If we fail the module load, we may try and cleanup before we even
> > allocate the GuC clients. KISS in order to try and re-enable
> > drv_module_reload for BAT.
> > 
> > Testcase: igt/drv_module_reload/basic-reload-inject
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michał Winiarski <michal.winiarski at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> 
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>
> 
> We want to fix the cleanup paths eventually though.

Yes, this is just band aid so we can reenable the test to be sure we
don't break the module unload as we do so.

Pushed along with the other simple cleanups for drv_module_reload,
thanks for the review.
-Chris


More information about the Intel-gfx mailing list