[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3] drm/i915/icl: Add remaining registers and bitfields for MG PHY DDI (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Jul 13 19:50:45 UTC 2018


== Series Details ==

Series: series starting with [v3] drm/i915/icl: Add remaining registers and bitfields for MG PHY DDI (rev3)
URL   : https://patchwork.freedesktop.org/series/45623/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ce48abb9636a drm/i915/icl: Add remaining registers and bitfields for MG PHY DDI
-:37: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ln0p1' - possible side-effects?
#37: FILE: drivers/gpu/drm/i915/i915_reg.h:1935:
+#define MG_PHY_PORT_LN(port, ln, ln0p1, ln0p2, ln1p1) \
 	_MMIO(_PORT((port) - PORT_C, ln0p1, ln0p2) + (ln) * ((ln1p1) - (ln0p1)))

total: 0 errors, 0 warnings, 1 checks, 276 lines checked
01e5f1c68b2a drm/i915/icl: Implement voltage swing programming sequence for MG PHY DDI
-:79: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#79: FILE: drivers/gpu/drm/i915/intel_ddi.c:2501:
+		val |= CRI_TXDEEMPH_OVERRIDE_17_12(

-:85: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#85: FILE: drivers/gpu/drm/i915/intel_ddi.c:2507:
+		val |= CRI_TXDEEMPH_OVERRIDE_17_12(

-:95: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#95: FILE: drivers/gpu/drm/i915/intel_ddi.c:2517:
+		val |= CRI_TXDEEMPH_OVERRIDE_5_0(

-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/i915/intel_ddi.c:2519:
+			CRI_TXDEEMPH_OVERRIDE_11_6(

-:105: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#105: FILE: drivers/gpu/drm/i915/intel_ddi.c:2527:
+		val |= CRI_TXDEEMPH_OVERRIDE_5_0(

-:107: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#107: FILE: drivers/gpu/drm/i915/intel_ddi.c:2529:
+			CRI_TXDEEMPH_OVERRIDE_11_6(

total: 0 errors, 0 warnings, 6 checks, 165 lines checked



More information about the Intel-gfx mailing list