[Intel-gfx] [PATCH 00/10] Improve crc-core driver interface
Kumar, Mahesh
mahesh1.kumar at intel.com
Mon Jul 16 14:24:24 UTC 2018
Hi,
thanks for the review.
On 7/12/2018 4:38 PM, Laurent Pinchart wrote:
> Hi Mahesh,
>
> Thank you for the patches.
>
> When resubmitting patch series, could you please add a version number to the
> [PATCH] prefix ? Otherwise it gets difficult to figure out which version is
> the latest. This can be done automatically with the -v argument to git-format-
> patch.
sure :), added patch prefix (now v4) and re-floated the series after
addressing review comments in patches 03/10, 08/10 & 10/10.
-Mahesh
>
> On Thursday, 12 July 2018 11:36:25 EEST Mahesh Kumar wrote:
>> This series improves crc-core <-> driver interface.
>> This series adds following functionality in the crc-core
>> - Now control node will print all the available sources if
>> implemented by driver along with current source.
>> - Setting of sorce will fail if provided source is not supported
>> - cleanup of crtc_crc_open function first allocate memory before
>> enabling CRC generation
>> - Don't block open() call instead wait in crc read call.
>>
>> Following IGT will fail due to crc-core <-> driver interface change
>> igt at kms_pipe_crc_basic@bad-source <now setting bad-source itself will fail>
>> ig at kms_pipe_crc_basic@nonblocking-crc-pipe-X
>> ig at kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence
>> In nonblocking crc tests we'll get lesser crc's due to skipping crc
>>
>> AMD/Rockchip/rcar code path is not validated and need inputs
>>
>> Cc: dri-devel at lists.freedesktop.org
>>
>> Mahesh Kumar (10):
>> drm: crc: Introduce verify_crc_source callback
>> drm: crc: Introduce get_crc_sources callback
>> drm/rockchip/crc: Implement verify_crc_source callback
>> drm/amdgpu_dm/crc: Implement verify_crc_source callback
>> drm/rcar-du/crc: Implement verify_crc_source callback
>> drm/i915/crc: implement verify_crc_source callback
>> drm/i915/crc: implement get_crc_sources callback
>> drm/crc: Cleanup crtc_crc_open function
>> Revert "drm: crc: Wait for a frame before returning from open()"
>> drm/rcar-du/crc: Implement get_crc_sources callback
>>
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +-
>> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 20 +++-
>> drivers/gpu/drm/drm_debugfs_crc.c | 92 +++++++++-------
>> drivers/gpu/drm/i915/intel_display.c | 2 +
>> drivers/gpu/drm/i915/intel_drv.h | 9 +-
>> drivers/gpu/drm/i915/intel_pipe_crc.c | 119 +++++++++++++++++-
>> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 82 +++++++++++---
>> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +
>> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 +
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 67 ++++++++++++
>> drivers/gpu/drm/rcar-du/rcar_du_kms.h | 1 +
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 26 ++++-
>> include/drm/drm_crtc.h | 40 ++++++-
>> 14 files changed, 396 insertions(+), 74 deletions(-)
More information about the Intel-gfx
mailing list