[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Make the audio component binding more generic (rev2)

[Patchwork]

== Series Details ==

Series: Make the audio component binding more generic (rev2)
URL   : https://patchwork.freedesktop.org/series/46603/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0158d4c929db drm/i915: Split audio component to a generic type
-:95: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#95: 
new file mode 100644

-:100: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#100: FILE: include/drm/drm_audio_component.h:1:
+// SPDX-License-Identifier: MIT

-:119: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#119: FILE: include/drm/drm_audio_component.h:20:
+	void (*get_power)(struct device *);

-:125: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#125: FILE: include/drm/drm_audio_component.h:26:
+	void (*put_power)(struct device *);

-:129: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#129: FILE: include/drm/drm_audio_component.h:30:
+	void (*codec_wake_override)(struct device *, bool enable);

-:133: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#133: FILE: include/drm/drm_audio_component.h:34:
+	int (*get_cdclk_freq)(struct device *);

-:140: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#140: FILE: include/drm/drm_audio_component.h:41:
+	int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);

-:153: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#153: FILE: include/drm/drm_audio_component.h:54:
+	int (*get_eld)(struct device *, int port, int pipe, bool *enabled,

-:324: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_audio_component_audio_ops *' should also have an identifier name
#324: FILE: include/sound/hda_i915.h:20:
+int snd_hdac_i915_register_notifier(const struct drm_audio_component_audio_ops *);

-:333: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#333: FILE: include/sound/hda_i915.h:52:
 }
+static inline int snd_hdac_i915_register_notifier(const struct drm_audio_component_audio_ops *ops)

total: 0 errors, 9 warnings, 1 checks, 464 lines checked
2b8e8a3a1c0e ALSA: hda/i915: Associate audio component with devres
-:47: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#47: FILE: include/sound/hda_i915.h:53:
 }
+static inline int snd_hdac_i915_register_notifier(struct hdac_bus *bus,

total: 0 errors, 0 warnings, 1 checks, 139 lines checked
8b0e4bd689b6 ALSA: hda: Make audio component support more generic
-:74: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_audio_component *' should also have an identifier name
#74: FILE: include/drm/drm_audio_component.h:90:
+	int (*master_bind)(struct device *dev, struct drm_audio_component *);

-:81: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_audio_component *' should also have an identifier name
#81: FILE: include/drm/drm_audio_component.h:97:
+	void (*master_unbind)(struct device *dev, struct drm_audio_component *);

-:86: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#86: 
new file mode 100644

-:91: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#91: FILE: include/sound/hda_component.h:1:
+// SPDX-License-Identifier: GPL-2.0

-:112: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#112: FILE: include/sound/hda_component.h:22:
+int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+				    const struct drm_audio_component_audio_ops *ops);

-:118: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#118: FILE: include/sound/hda_component.h:28:
+}
+static inline int snd_hdac_display_power(struct hdac_bus *bus, bool enable)

-:122: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#122: FILE: include/sound/hda_component.h:32:
+}
+static inline int snd_hdac_sync_audio_rate(struct hdac_device *codec,

-:127: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#127: FILE: include/sound/hda_component.h:37:
+}
+static inline int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid,

-:133: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#133: FILE: include/sound/hda_component.h:43:
+}
+static inline int snd_hdac_acomp_init(struct hdac_bus *bus,

-:140: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#140: FILE: include/sound/hda_component.h:50:
+}
+static inline int snd_hdac_acomp_exit(struct hdac_bus *bus)

-:144: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#144: FILE: include/sound/hda_component.h:54:
+}
+static inline int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,

-:145: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#145: FILE: include/sound/hda_component.h:55:
+static inline int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+						  const struct drm_audio_component_audio_ops *ops)

-:492: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#492: FILE: sound/hda/hdac_component.c:239:
+int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+				    const struct drm_audio_component_audio_ops *aops)

-:1060: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1060: FILE: sound/pci/hda/patch_hdmi.c:2546:
+	snd_hdac_acomp_register_notifier(&codec->bus->core,
 					&spec->drm_audio_ops);

total: 0 errors, 4 warnings, 10 checks, 971 lines checked