[Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix GuC pin bias and WOPCM initialization order

Michal Wajdeczko michal.wajdeczko at intel.com
Tue Jul 17 12:23:54 UTC 2018


On Tue, 17 Jul 2018 14:09:16 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Jakub BartmiĊ„ski (2018-07-17 12:55:58)
>> It would seem that we are using uninitialized WOPCM variables when
>> setting the GuC pin bias. The pin bias has to be set after the WOPCM,
>> but before the call to i915_gem_contexts_init where the first contexts
>> are pinned so the safest place to set it seems to be right after
>> initializing the relevant variables in intel_wopcm_init.
>
> Oops, do you have a Fixes?

Ha, it could be my fault: intel_wopcm_init and intel_uc_init_misc were
swapped in ("drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific  
init")

Michal


More information about the Intel-gfx mailing list