[Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Move the pin bias value from GuC to GGTT

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 18 12:10:48 UTC 2018


Quoting Jakub BartmiĊ„ski (2018-07-18 12:54:09)
> +u32 intel_guc_ggtt_offset(struct intel_guc *guc, struct i915_vma *vma)
> +{
> +       struct drm_i915_private *i915 = guc_to_i915(guc);

Unused i915 if you disable debug.

> +
> +       u32 offset = i915_ggtt_offset(vma);
> +
> +       GEM_BUG_ON(offset < i915->ggtt.pin_bias);
GEM_BUG_ON(offset < i915_vm_to_ggtt(vma->vm)->pin_bias);

seems to be the most self-contained way to express it.
-Chris


More information about the Intel-gfx mailing list