[Intel-gfx] [PATCH] drm/i915/guc: Keep guc submission permanently engaged

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 19 09:15:34 UTC 2018


Quoting Michał Winiarski (2018-07-19 10:10:22)
> On Tue, Jul 17, 2018 at 09:29:32PM +0100, Chris Wilson wrote:
> > We make a decision at module load whether to use the GuC backend or not,
> > but lose that setup across set-wedge. Currently, the guc doesn't
> > override the engine->set_default_submission hook letting execlists sneak
> > back in temporarily on unwedging leading to an unbalanced park/unpark.
> > 
> > v2: Remove comment about switching back temporarily to execlists on
> > guc_submission_disable(). We currently only call disable on shutdown,
> > and plan to also call disable before suspend and reset, in which case we
> > will either restore guc submission or mark the driver as wedged, making
> > the reset back to execlists pointless.
> > v3: Move reset.prepare across
> > 
> > Testcase: igt/drv_module_reload/basic-reload-inject
> > Testcase: igt/gem_eio
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michał Winiarski <michal.winiarski at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> 
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

Ta, and with everything that purports to fix the elusive
basic-reload-inject, I now need to find an igt patch and victim.
-Chris


More information about the Intel-gfx mailing list