[Intel-gfx] [PATCH] drm/i915: Pull unpin map into vma release

Michał Winiarski michal.winiarski at intel.com
Tue Jul 24 08:48:59 UTC 2018


On Sat, Jul 21, 2018 at 01:50:37PM +0100, Chris Wilson wrote:
> A reasonably common operation is to pin the map of the vma alongside the
> vma itself for the lifetime of the vma, and so release both pin at the
> same time as destroying the vma. It is common enough to pull into the
> release function, making that central function more attractive to a
> couple of other callsites.
> 
> The continual ulterior motive is to sweep over errors on module load
> aborting...
> 
> Testcase: igt/drv_module_reload/basic-reload-inject
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiarski at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>

Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

-Michał

> ---
>  drivers/gpu/drm/i915/i915_perf.c            | 10 ++++------
>  drivers/gpu/drm/i915/i915_vma.c             |  5 ++++-
>  drivers/gpu/drm/i915/i915_vma.h             |  3 ++-
>  drivers/gpu/drm/i915/intel_engine_cs.c      | 18 +++---------------
>  drivers/gpu/drm/i915/intel_guc.c            |  5 ++---
>  drivers/gpu/drm/i915/intel_guc_ads.c        |  2 +-
>  drivers/gpu/drm/i915/intel_guc_ct.c         |  7 ++-----
>  drivers/gpu/drm/i915/intel_guc_log.c        |  2 +-
>  drivers/gpu/drm/i915/intel_guc_submission.c | 10 ++++------
>  drivers/gpu/drm/i915/intel_lrc.c            |  2 +-
>  10 files changed, 24 insertions(+), 40 deletions(-)


More information about the Intel-gfx mailing list