[Intel-gfx] [igt-dev] [PATCH i-g-t v6 2/4] lib/igt_pm: Find HDA device when attempting to enable runtime PM

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 24 12:27:16 UTC 2018


Quoting Tvrtko Ursulin (2018-07-24 11:29:31)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> HDA audio device can be present at various PCI paths on different systems
> which the existing code did not account for.
> 
> Furthermore the failure to enable runtime PM was silent leaving callers
> in the dark.
> 
> Improve it by auto-locating the PCI path and logging a warning when
> something is not as expected.
> 
> v2:
>  * If there is no audio hw/driver there is no failure.
> 
> v3:
>  * Comment.
>  * Skip non-symlinks.
>  * Free path on failure and restore.
>  * Simplify with asprintf. (Chris Wilson)
> 
> v4:
>  * Find snd_hda_intel instance tied with an Intel device.
> 
> v5:
>  * Fix memory leak and silence Valgrind warning.
> 
> v6:
>  * Fix error out logic.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

CI looks promising, as far my knowledge goes (and I am sorry to say
finding the child devices is beyond my sysfs ken), series is
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list