[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Added max_bpp property to limit maximum bpp even if HDMI TV advertises higher limit.

Patchwork patchwork at emeril.freedesktop.org
Thu Jul 26 13:36:48 UTC 2018


== Series Details ==

Series: Added max_bpp property to limit maximum bpp even if HDMI TV advertises higher limit.
URL   : https://patchwork.freedesktop.org/series/47286/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e194ce13c27e Added max_bpp property to limit maximum bpp even if HDMI TV advertises higher limit.
-:136: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#136: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2103:
+	to_intel_digital_connector_state(connector->state)->max_bpp = 8*3;
 	                                                               ^

-:156: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#156: FILE: drivers/gpu/drm/i915/intel_modes.c:108:
+	if (prop == NULL) {

-:158: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#158: FILE: drivers/gpu/drm/i915/intel_modes.c:110:
+		prop = drm_property_create_range(dev, 0,
+			"Max bpp", 0, 12*3);

-:158: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#158: FILE: drivers/gpu/drm/i915/intel_modes.c:110:
+			"Max bpp", 0, 12*3);
 			                ^

-:159: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#159: FILE: drivers/gpu/drm/i915/intel_modes.c:111:
+		if (prop == NULL)

-:165: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#165: FILE: drivers/gpu/drm/i915/intel_modes.c:117:
+	drm_object_attach_property(&connector->base, prop, 8*3);
 	                                                    ^

total: 0 errors, 0 warnings, 6 checks, 116 lines checked



More information about the Intel-gfx mailing list