[Intel-gfx] [PATCH] drm/i915/execlists: Terminate the context image with BB_END

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 31 21:58:41 UTC 2018


Quoting Lionel Landwerlin (2018-07-31 13:47:32)
> On 30/07/18 17:43, Chris Wilson wrote:
> > In the aub trace utility, the context images are terminated with a
> > MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
> > Do the same for our protocontext image for completeness, and in passing
> > apply the magic bit for gen10 to mark the end of the context image.
> >
> > Reported-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> 
> Doesn't look like anything exploded.
> Have you noticed any improvement maybe in the benchmarks?

Haven't found anything that shows a difference. I expect that after the
first save, the context image has grown the BB_END.

I was going to dissect the default context image to see if that was
true.
-Chris


More information about the Intel-gfx mailing list