[Intel-gfx] [PATCH] drm/i915: Check intel_contexts to avoid one extra pointer chase

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri Jun 1 10:05:18 UTC 2018


Chris Wilson <chris at chris-wilson.co.uk> writes:

> As we store the intel_context on the request (rq->hw_context), we can
> simply compare that against the local intel_context for the
> i915->kernel_context rather than using the rq->gem_context.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 81f086397d10..94e4db1870aa 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -610,7 +610,7 @@ static bool engine_has_kernel_context_barrier(struct intel_engine_cs *engine)
>  
>  		any_active = true;
>  
> -		if (rq->gem_context == i915->kernel_context)
> +		if (rq->hw_context == ce)

We lose a little bit of readability due to that 'ce'.
But the function is compact enough so that it shows it's
nature in one eyeful. Tho you could introduce 'kec' :)

With or without,
Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

>  			continue;
>  
>  		/*
> -- 
> 2.17.1


More information about the Intel-gfx mailing list