[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/i915/gtt: Rename i915_hw_ppgtt base member

[Patchwork]

== Series Details ==

Series: series starting with [01/11] drm/i915/gtt: Rename i915_hw_ppgtt base member
URL   : https://patchwork.freedesktop.org/series/44244/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f1e88b978f6f drm/i915/gtt: Rename i915_hw_ppgtt base member
-:39: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#39: FILE: drivers/gpu/drm/i915/gvt/gvt.h:364:
+#define gvt_ggtt_gm_sz(gvt)	  (gvt->dev_priv->ggtt.vm.total)

-:124: WARNING:LONG_LINE: line over 100 characters
#124: FILE: drivers/gpu/drm/i915/i915_gem.c:1227:
+					     i915_gem_object_get_dma_address(obj, offset >> PAGE_SHIFT),

-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: drivers/gpu/drm/i915/i915_gem.c:1429:
+					     i915_gem_object_get_dma_address(obj, offset >> PAGE_SHIFT),

-:497: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#497: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1984:
+	BUG_ON(!drm_mm_initialized(&ggtt->vm.mm));

-:1208: ERROR:SPACING: spaces required around that '?' (ctx:VxW)
#1208: FILE: drivers/gpu/drm/i915/i915_trace.h:978:
+			__entry->vm = to->ppgtt? &to->ppgtt->vm : NULL;
 			                       ^

-:1541: ERROR:CODE_INDENT: code indent should use tabs where possible
#1541: FILE: drivers/gpu/drm/i915/selftests/huge_pages.c:1594:
+^I       ^Ictx->ppgtt ? &ctx->ppgtt->vm : &i915->ggtt.vm;$

-:1541: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1541: FILE: drivers/gpu/drm/i915/selftests/huge_pages.c:1594:
+^I       ^Ictx->ppgtt ? &ctx->ppgtt->vm : &i915->ggtt.vm;$

-:1894: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1894: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1273:
+	     total + 2*I915_GTT_PAGE_SIZE <= i915->ggtt.vm.total;
 	              ^

-:1927: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1927: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1322:
+	     total + 2*I915_GTT_PAGE_SIZE <= i915->ggtt.vm.total;
 	              ^

-:2083: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#2083: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1582:
+	     total + 2*I915_GTT_PAGE_SIZE <= i915->ggtt.vm.total;
 	              ^

-:2138: WARNING:LONG_LINE: line over 100 characters
#2138: FILE: drivers/gpu/drm/i915/selftests/i915_gem_object.c:314:
+			      (1 + next_prime_number(i915->ggtt.vm.total >> PAGE_SHIFT)) << PAGE_SHIFT);

total: 2 errors, 5 warnings, 4 checks, 2084 lines checked
7a2d47cc358a drm/i915/gtt: Teach restore-gtt to walk the ggtt vma list not the object list
cc39095ecd03 drm/i915: Prepare for non-object vma
10c5a34b2e15 drm/i915: Decouple vma vfuncs from vm
4bfb5a70abf2 drm/i915/gtt: Push allocation to hw ppgtt constructor
456ff6928b6b drm/i915/gtt: Subclass gen6_hw_ppgtt
-:323: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'base' - possible side-effects?
#323: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:418:
+#define __to_gen6_ppgtt(base) container_of(base, struct gen6_hw_ppgtt, base)

total: 0 errors, 0 warnings, 1 checks, 342 lines checked
8c7849ff7796 drm/i915/gtt Onionify error handling for gen6_ppgtt_create
15aa72fb3e6f drm/i915/gtt: Reorder aliasing_ppgtt fini
1ac4a9a25c0b drm/i915/gtt: Make gen6 page directories evictable
-:235: WARNING:MEMORY_BARRIER: memory barrier without comment
#235: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1991:
+	wmb();

-:262: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!vma"
#262: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:2018:
+	if (vma == NULL)

total: 0 errors, 1 warnings, 1 checks, 362 lines checked
a1d36edef4b0 drm/i915/gtt: Only keep gen6 page directories pinned while active
6da02c7420cb RFT drm/i915/gtt: Enable full-ppgtt by default everywhere