[Intel-gfx] [PATCH 06/11] drm/i915/gtt: Subclass gen6_hw_ppgtt

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Jun 5 09:43:14 UTC 2018


Quoting Chris Wilson (2018-06-05 10:19:44)
> The legacy gen6 ppgtt needs a little more hand holding than gen8+, and
> so requires a larger structure. As I intend to make this slightly more
> complicated in the future, separate the gen6 from the core gen8 hw
> struct by subclassing. This patch moves the gen6 only features out to
> gen6_hw_ppgtt and pipes the new type everywhere that needs it.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Cc: Matthew Auld <matthew.william.auld at gmail.com>

It's at times confusing when gen6_foo takes either the ppgtt or
ppgtt->base, but at least compiler will protect from that.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas


More information about the Intel-gfx mailing list