[Intel-gfx] [PATCH 01/11] drm/i915/gtt: Rename i915_hw_ppgtt base member

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 5 14:41:43 UTC 2018


Quoting Mika Kuoppala (2018-06-05 15:38:09)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > In the near future, I want to subclass gen6_hw_ppgtt as it contains a
> > few specialised members and I wish to add more. To avoid the ugliness of
> > using ppgtt->base.base, rename the i915_hw_ppgtt base member
> > (i915_address_space) as vm, which is our common shorthand for an
> > i915_address_space local.
> >
> 
> Strolled it through. Couple of formatting fixes and
> getting dev_priv through vm. Didn't notice anything
> out of ordinary.
> 
> For me it reads better now, and we should have done this
> prior to doing 32bit ppgtts :P

The nuisance one for me is ggtt->vm.mm, I think we could do with calling
the drm_mm mgr, i.e. ggtt->vm.mgr. We may also want to rename vma as
iova to follow other drivers.
-Chris


More information about the Intel-gfx mailing list