[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Rename i915_hw_ppgtt base member

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 5 16:48:20 UTC 2018


== Series Details ==

Series: drm/i915/gtt: Rename i915_hw_ppgtt base member
URL   : https://patchwork.freedesktop.org/series/44285/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a6b1f5bb4b67 drm/i915/gtt: Rename i915_hw_ppgtt base member
-:40: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#40: FILE: drivers/gpu/drm/i915/gvt/gvt.h:364:
+#define gvt_ggtt_gm_sz(gvt)	  (gvt->dev_priv->ggtt.vm.total)

-:125: WARNING:LONG_LINE: line over 100 characters
#125: FILE: drivers/gpu/drm/i915/i915_gem.c:1227:
+					     i915_gem_object_get_dma_address(obj, offset >> PAGE_SHIFT),

-:148: WARNING:LONG_LINE: line over 100 characters
#148: FILE: drivers/gpu/drm/i915/i915_gem.c:1429:
+					     i915_gem_object_get_dma_address(obj, offset >> PAGE_SHIFT),

-:498: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#498: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1984:
+	BUG_ON(!drm_mm_initialized(&ggtt->vm.mm));

-:1901: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1901: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1273:
+	     total + 2*I915_GTT_PAGE_SIZE <= i915->ggtt.vm.total;
 	              ^

-:1934: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1934: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1322:
+	     total + 2*I915_GTT_PAGE_SIZE <= i915->ggtt.vm.total;
 	              ^

-:2090: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#2090: FILE: drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1582:
+	     total + 2*I915_GTT_PAGE_SIZE <= i915->ggtt.vm.total;
 	              ^

-:2145: WARNING:LONG_LINE: line over 100 characters
#2145: FILE: drivers/gpu/drm/i915/selftests/i915_gem_object.c:314:
+			      (1 + next_prime_number(i915->ggtt.vm.total >> PAGE_SHIFT)) << PAGE_SHIFT);

total: 0 errors, 4 warnings, 4 checks, 2090 lines checked



More information about the Intel-gfx mailing list