[Intel-gfx] [PATCH i-g-t] igt/drv_module_reload: Revamp fault-injection

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 6 14:30:00 UTC 2018


Quoting Michał Winiarski (2018-06-06 15:18:14)
> On Wed, Jun 06, 2018 at 02:09:16PM +0100, Chris Wilson wrote:
> > The current method of checking for a failed module load is flawed, as we
> > only report the error on probing it is not being reported back by
> > modprobe. So we have to dig inside the module_parameters while the
> > module is still loaded to discover the error.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michał Winiarski <michal.winiarski at intel.com>
> > Cc: Imre Deak <imre.deak at intel.com>
> 
> That also works.
> 
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>
> 
> Should we push now? Or delay until we fix i915?

We wait a bit to fix i915. But the corresponding kernel patch should be
clean to go (well hopefully v2!).
-Chris


More information about the Intel-gfx mailing list