[Intel-gfx] [PATCH v3] drm/i915: Mark i915.inject_load_failure as being hit

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 6 17:40:41 UTC 2018


Quoting Michal Wajdeczko (2018-06-06 15:54:47)
> On Wed, 06 Jun 2018 16:50:09 +0200, Michał Winiarski  
> <michal.winiarski at intel.com> wrote:
> 
> > On Wed, Jun 06, 2018 at 03:41:53PM +0100, Chris Wilson wrote:
> >> When we reach the magic value and do inject a fault into our module  
> >> load,
> >> mark the module option as being hit. Since we fail from inside pci
> >> probe, the module load isn't actually aborted and the module (and
> >> paramters) are left lingering. igt can then inspect the parameter on its
> 
> still typo here
> 
> >> synchronous completion of modprobe to see if the fault injection was
> >> successful, and will keeping on injecting new faults until the module
> >> succeeds in loading having surpassed the number of fault points.
> >>
> >> v2: Reset to 0 after being hit;
> >>
> >> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >> Cc: Michał Winiarski <michal.winiarski at intel.com>
> >> Cc: Imre Deak <imre.deak at intel.com>
> >
> > If the other Michał doesn't mind ;)
> 
> it depends ;)
> 
> with typo fixed, you can have my r-b too

Deal.

Thanks for pointing out how broken the igt was, grrr :-p
Pushed,
-Chris


More information about the Intel-gfx mailing list