[Intel-gfx] [PATCH] drm/i915: Use GEM suspend when aborting initialisation

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 7 07:43:54 UTC 2018


Quoting Michał Winiarski (2018-06-07 08:39:39)
> On Wed, Jun 06, 2018 at 03:54:41PM +0100, Chris Wilson wrote:
> > As part of our GEM initialisation now, we send a request to the hardware
> > in order to record the initial GPU state. This coupled with deferred
> > idle workers, makes aborting on error tricky. We already have the
> > mechanism in place to wait on the GPU and cancel all the deferred
> > workers for suspend, so let's reuse it during the error teardown. It is
> > already used in places for later init error handling, but doing so at
> > this point is slightly ugly due to the mutex dance (it's ok, the module
> > load is still single threaded).
> > 
> > Testcase: igt/drv_module_reload/basic-reload-inject
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Michał Winiarski <michal.winiarski at intel.com>
> 
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

And pushed. Now let's see how close we are to making CI great again!

Quick! Where's my coffee?
-Chris


More information about the Intel-gfx mailing list