[Intel-gfx] [PATCH] drm/i915: inline skl_copy_ddb_for_pipe() to its only caller

[Chris Wilson]

Quoting Paulo Zanoni (2018-06-08 00:07:00)
>  static void
>  skl_print_wm_changes(const struct drm_atomic_state *state)
>  {
> @@ -5381,7 +5370,10 @@ static void skl_initial_wm(struct intel_atomic_state *state,
>         if (cstate->base.active_changed)
>                 skl_atomic_update_crtc_wm(state, cstate);
>  
> -       skl_copy_ddb_for_pipe(hw_vals, results, pipe);
> +       memcpy(hw_vals->ddb.uv_plane[pipe], results->ddb.uv_plane[pipe],
> +              sizeof(hw_vals->ddb.uv_plane[pipe]));

I must be seeing things.

ddb.uv_plane[pipe] must be a pointer, right?
Therefore sizeof(ddb.uv_plane[pipe]) must the size of that pointer and
not of the struct. Do you not mean sizeof(*ddb.uv_plane[pipe]) ?

Definitely time to stop reading code...
-Chris