[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Enable KVMGT for BXT

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 11 08:47:42 UTC 2018 

== Series Details ==

Series: drm/i915/gvt: Enable KVMGT for BXT
URL   : https://patchwork.freedesktop.org/series/44551/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b5fc25abca3a drm/i915/gvt: Add D_BXT device type define for BXT.
3e9372b719bd drm/i915/gvt: Add MEDIA_POOL_STATE for BXT.
9d572b34c392 drm/i915/gvt: Enable device info initialization for BXT.
090b34bd14a7 drm/i915/gvt: Enable gtt initialization for BXT.
24d7aaaedc8e drm/i915/gvt: Enable irq initialization for BXT.
-:24: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#24: FILE: drivers/gpu/drm/i915/gvt/interrupt.c:584:
+	} else if (IS_SKYLAKE(gvt->dev_priv)
+			|| IS_KABYLAKE(gvt->dev_priv)

-:25: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#25: FILE: drivers/gpu/drm/i915/gvt/interrupt.c:585:
+			|| IS_KABYLAKE(gvt->dev_priv)
+			|| IS_BROXTON(gvt->dev_priv)) {

total: 0 errors, 0 warnings, 2 checks, 26 lines checked
8beba6a3b183 drm/i915/gvt: Enable mmio context init and switch for BXT.
-:20: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#20: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:368:
+	if (ring_id == RCS && (IS_SKYLAKE(dev_priv) ||
+			IS_KABYLAKE(dev_priv) || IS_BROXTON(dev_priv)))

-:39: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#39: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:472:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:40: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#40: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:473:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv))

-:50: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#50: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:486:
+		if ((IS_KABYLAKE(dev_priv) || IS_BROXTON(dev_priv))
+			&& mmio->in_context)

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/gpu/drm/i915/gvt/mmio_context.c:582:
+	if (IS_SKYLAKE(gvt->dev_priv) ||
+		IS_KABYLAKE(gvt->dev_priv) ||

total: 0 errors, 0 warnings, 5 checks, 46 lines checked
f577b2fa2168 drm/i915/gvt: Enable cmd_parser support for BXT.
-:24: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#24: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1261:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:25: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#25: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1262:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv)) {

-:35: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#35: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1291:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:36: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#36: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1292:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv)) {

-:46: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#46: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1317:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:47: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#47: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1318:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv))

-:92: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#92: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:1615:
+	if (cmd_val(s, 0) & (1 << 8) &&
 			!(s->vgpu->scan_nonprivbb & (1 << s->ring_id)))

total: 0 errors, 0 warnings, 7 checks, 76 lines checked
23b9b94e088e drm/i915/gvt: Enable force wake support for BXT.
-:22: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#22: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:302:
+	if ((IS_KABYLAKE(req->i915) || IS_BROXTON(req->i915))
+		&& is_inhibit_context(req->hw_context))

-:31: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#31: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:905:
 	bool need_force_wake = IS_SKYLAKE(gvt->dev_priv)
+			|| IS_KABYLAKE(gvt->dev_priv)

-:32: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#32: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:906:
+			|| IS_KABYLAKE(gvt->dev_priv)
+			|| IS_BROXTON(gvt->dev_priv);

total: 0 errors, 0 warnings, 3 checks, 18 lines checked
b6d0b640b71b drm/i915/gvt: Enable virtual display support for BXT.
63f23bbc442d drm/i915/gvt: Enable dma_buf support for BXT.
-:20: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#20: FILE: drivers/gpu/drm/i915/gvt/dmabuf.c:168:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:21: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#21: FILE: drivers/gpu/drm/i915/gvt/dmabuf.c:169:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv)) {

-:35: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#35: FILE: drivers/gpu/drm/i915/gvt/fb_decoder.c:154:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:36: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#36: FILE: drivers/gpu/drm/i915/gvt/fb_decoder.c:155:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv)) {

-:46: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#46: FILE: drivers/gpu/drm/i915/gvt/fb_decoder.c:220:
+	if (IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:47: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#47: FILE: drivers/gpu/drm/i915/gvt/fb_decoder.c:221:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv)) {

-:57: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#57: FILE: drivers/gpu/drm/i915/gvt/fb_decoder.c:264:
+		(IS_SKYLAKE(dev_priv)
+		|| IS_KABYLAKE(dev_priv)

-:58: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#58: FILE: drivers/gpu/drm/i915/gvt/fb_decoder.c:265:
+		|| IS_KABYLAKE(dev_priv)
+		|| IS_BROXTON(dev_priv)) ?

total: 0 errors, 0 warnings, 8 checks, 40 lines checked
94e312e4b2c8 drm/i915/gvt: Add mmio handler for for BXT.
-:20: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#20: FILE: drivers/gpu/drm/i915/gvt/handlers.c:260:
 	if (IS_SKYLAKE(vgpu->gvt->dev_priv)
+		|| IS_KABYLAKE(vgpu->gvt->dev_priv)

-:21: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#21: FILE: drivers/gpu/drm/i915/gvt/handlers.c:261:
+		|| IS_KABYLAKE(vgpu->gvt->dev_priv)
+		|| IS_BROXTON(vgpu->gvt->dev_priv)) {

-:30: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#30: FILE: drivers/gpu/drm/i915/gvt/handlers.c:863:
 	if ((IS_SKYLAKE(vgpu->gvt->dev_priv)
+		|| IS_KABYLAKE(vgpu->gvt->dev_priv)

-:31: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#31: FILE: drivers/gpu/drm/i915/gvt/handlers.c:864:
+		|| IS_KABYLAKE(vgpu->gvt->dev_priv)
+		|| IS_BROXTON(vgpu->gvt->dev_priv))

-:71: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#71: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1468:
+static int bxt_de_pll_enable_write(struct intel_vgpu *vgpu,
+		unsigned int offset, void *p_data, unsigned int bytes)

-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1481:
+static int bxt_port_pll_enable_write(struct intel_vgpu *vgpu,
+		unsigned int offset, void *p_data, unsigned int bytes)

-:97: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#97: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1494:
+static int bxt_phy_ctl_family_write(struct intel_vgpu *vgpu,
+		unsigned int offset, void *p_data, unsigned int bytes)

-:112: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#112: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1509:
+static int bxt_port_tx_dw3_read(struct intel_vgpu *vgpu,
+		unsigned int offset, void *p_data, unsigned int bytes)

-:124: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#124: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1521:
+static int bxt_pcs_dw12_grp_write(struct intel_vgpu *vgpu,
+		unsigned int offset, void *p_data, unsigned int bytes)

-:142: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#142: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1539:
+static int bxt_gt_disp_pwron_write(struct intel_vgpu *vgpu,
+		unsigned int offset, void *p_data, unsigned int bytes)

-:160: CHECK:LINE_SPACING: Please don't use multiple blank lines
#160: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1557:
+
+

-:219: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#219: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2931:
+	MMIO_F(_MMIO(0xc800), 0x7f8, F_CMD_ACCESS, 0, 0, D_SKL_PLUS,
+		NULL, NULL);

-:221: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#221: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2933:
+	MMIO_F(_MMIO(0xb020), 0x80, F_CMD_ACCESS, 0, 0, D_SKL_PLUS,
+		NULL, NULL);

-:229: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#229: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2940:
+	MMIO_DFH(_MMIO(0x20ec), D_SKL_PLUS, F_MODE_MASK | F_CMD_ACCESS,
+		NULL, NULL);

-:245: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#245: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2949:
+	MMIO_DFH(_MMIO(0x4df4), D_SKL_PLUS, F_CMD_ACCESS,
+		NULL, gen9_trtte_write);

-:290: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#290: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2990:
+	MMIO_DFH(GEN8_HDC_CHICKEN1, D_SKL_PLUS, F_MODE_MASK | F_CMD_ACCESS,
 		NULL, NULL);

total: 0 errors, 0 warnings, 16 checks, 465 lines checked
ddc3797a801f drm/i915: Enable KVMGT for BXT.

More information about the Intel-gfx mailing list