[Intel-gfx] [PATCH] drm/i915/psr: Adds psrwake options for all platforms

[Jani Nikula]

On Tue, 12 Jun 2018, vathsala nagaraju <vathsala.nagaraju at intel.com> wrote:
> From: Vathsala Nagaraju <vathsala.nagaraju at intel.com>
>
> Adds new psrwake options defined in the below table.
> Platform	PSR wake options vbt version
> KBL/CFL/WHL	All
> SKL		All PV releases (Check for 203+ might help but cannot be foolproof)
> BXT		Uses old interpretation.
> CNL/ICL+	All
> GLK		All
>
> For SKL, we will continue to use older interpretation for the above reason.
>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Puthikorn Voravootivat <puthik at chromium.org>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
>
> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 465dff4..010ff68 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -710,7 +710,8 @@ static int intel_bios_ssc_frequency(struct drm_i915_private *dev_priv,
>  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us
>  	 * Old decimal value is wake up time in multiples of 100 us.
>  	 */
> -	if (bdb->version >= 209 && IS_GEN9_BC(dev_priv)) {
> +	if ((INTEL_GEN(dev_priv) >= 10) ||
> +	    (IS_GEN9_BC(dev_priv) && !IS_SKYLAKE(dev_priv))) {

Please keep the version check.

Please tell anyone who asks, and also those who don't, that *all* of the
VBT changes should be based on the *version*, and *none* of them should
be based on the *platform*.

BR,
Jani.

>  		switch (psr_table->tp1_wakeup_time) {
>  		case 0:
>  			dev_priv->vbt.psr.tp1_wakeup_time_us = 500;

-- 
Jani Nikula, Intel Open Source Graphics Center