[Intel-gfx] [PATCH] drm/i915: Allow DBLSCAN user modes with eDP/LVDS/DSI

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Jun 13 18:11:37 UTC 2018


On Wed, Jun 13, 2018 at 04:48:29PM +0200, Maarten Lankhorst wrote:
> Op 24-05-18 om 14:54 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > When encountering a connector with the scaling mode property both
> > intel and modesetting ddxs sometimes add tons of DBLSCAN modes
> > to the output's mode list. The idea presumably being that since the
> > output will be going through the panel fitter anyway we can pretend
> > to use any kind of mode.
> >
> > Sadly that means we can't reject user modes with the DBLSCAN flag
> > until we know whether we're going to be using the panel's native
> > mode or the user mode directly. Doing otherwise means X clients using
> > xf86vidmode/xrandr will get a protocol error (and often self
> > terminate as a result) when the kernel refuses to use the requested
> > mode with the DBLSCAN flag.
> >
> > To undo the regression we'll move the DBLSCAN checks into the
> > connector->mode_valid() and encoder->compute_config() hooks.
> >
> > Cc: Vito Caputo <vcaputo at pengaru.com>
> > Reported-by: Vito Caputo <vcaputo at pengaru.com>
> > Fixes: e995ca0b8139 ("drm/i915: Provide a device level .mode_valid() hook")
> > References: https://lkml.org/lkml/2018/5/21/715
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
<snip> 
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

Thanks. Pushed to dinq with
Cc: stable at vger.kernel.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106804
Tested-by: Arkadiusz Miskiewicz <arekm at maven.pl>

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list