[Intel-gfx] [PATCH 13/24] drm/i915/icl: unconditionally init DDI for every port

Lucas De Marchi lucas.de.marchi at gmail.com
Wed Jun 13 23:34:57 UTC 2018


On Mon, May 21, 2018 at 05:25:47PM -0700, Paulo Zanoni wrote:
> On ICP, port present straps are no longer supported. Software should

ICP?? Doesn't it make more sense to say on ICL here?

> determine the presence through BIOS VBT, hotplug or other mechanisms.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

> ---
>  drivers/gpu/drm/i915/intel_display.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d5a19c1b3b20..528d9f9c456d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13965,7 +13965,14 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>  	if (intel_crt_present(dev_priv))
>  		intel_crt_init(dev_priv);
>  
> -	if (IS_GEN9_LP(dev_priv)) {
> +	if (IS_ICELAKE(dev_priv)) {
> +		intel_ddi_init(dev_priv, PORT_A);
> +		intel_ddi_init(dev_priv, PORT_B);
> +		intel_ddi_init(dev_priv, PORT_C);
> +		intel_ddi_init(dev_priv, PORT_D);
> +		intel_ddi_init(dev_priv, PORT_E);
> +		intel_ddi_init(dev_priv, PORT_F);
> +	} else if (IS_GEN9_LP(dev_priv)) {
>  		/*
>  		 * FIXME: Broxton doesn't support port detection via the
>  		 * DDI_BUF_CTL_A or SFUSE_STRAP registers, find another way to
> -- 
> 2.14.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list