[Intel-gfx] [PATCH 2/3] drm/i915/execlists: Push the tasklet kick after reset to reset_finish

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 14 18:38:12 UTC 2018


Quoting Mika Kuoppala (2018-06-14 16:48:48)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > In the unlikely case where we have failed to keep submitting to the GPU,
> > we end up with the ELSP queue empty but a pending queue of requests.
> > Here, we skip the per-engine reset as there is no guilty request, but in
> > doing so we also skip the engine restart leaving ourselves with a
> > permanently hung engine. A quick way to recover is by moving the tasklet
> > kick to execlists_reset_finish() (from init_hw). We still emit the error
> > on hanging, so the error is not lost but we should be able to recover.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

Thanks for the review, pushed.
-Chris


More information about the Intel-gfx mailing list