[Intel-gfx] [PATCH] drm/i915/execlists: Pull the w/a LRI emission into a helper

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Jun 18 11:01:16 UTC 2018


Quoting Chris Wilson (2018-06-18 12:41:50)
> Having the w/a registers as an open-coded table leaves a trap for the
> unwary; it would be easy to miss incrementing the LRI counter when
> adding a new register to the list. Instead, pull the list of registers
> into a table, so that we only need add new registers to that table
> rather than try and remember important side-effects of earlier chunks of
> GPU instructions.
> 
> Suggested-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Not related to this patch, but the lack of OOB check for batch makes
one itch a little bit.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas


More information about the Intel-gfx mailing list