[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/31] drm/i915: Defer modeset cleanup to a secondary task

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 25 10:32:25 UTC 2018 

== Series Details ==

Series: series starting with [01/31] drm/i915: Defer modeset cleanup to a secondary task
URL   : https://patchwork.freedesktop.org/series/45325/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a3ac02da008c drm/i915: Defer modeset cleanup to a secondary task
c9eb2b49fcc6 drm/i915/execlists: Check for ce->state before destroy
04fd713eba93 drm/i915/execlists: Pull submit after dequeue under timeline lock
54044bcfdbcc drm/i915/execlists: Pull CSB reset under the timeline.lock
8b04d5a54778 drm/i915/execlists: Process one CSB update at a time
-:45: WARNING:MEMORY_BARRIER: memory barrier without comment
#45: FILE: drivers/gpu/drm/i915/intel_lrc.c:972:
+	smp_mb__after_atomic();

-:91: WARNING:LONG_LINE: line over 100 characters
#91: FILE: drivers/gpu/drm/i915/intel_lrc.c:996:
+		  head, GEN8_CSB_READ_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?",

-:92: WARNING:LONG_LINE: line over 100 characters
#92: FILE: drivers/gpu/drm/i915/intel_lrc.c:997:
+		  tail, GEN8_CSB_WRITE_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?");

-:160: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#160: FILE: drivers/gpu/drm/i915/intel_lrc.c:1028:
+			  status, buf[2*head + 1],
 			               ^

-:188: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#188: FILE: drivers/gpu/drm/i915/intel_lrc.c:1046:
+		    buf[2*head + 1] == execlists->preempt_complete_status) {
 		         ^

total: 0 errors, 3 warnings, 2 checks, 303 lines checked
f819c2f9ca9e drm/i915/execlists: Unify CSB access pointers
737fbd87f197 drm/i915/execlists: Direct submission of new requests (avoid tasklet/ksoftirqd)
-:102: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#102: 
References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")

-:102: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")'
#102: 
References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")

total: 1 errors, 1 warnings, 0 checks, 358 lines checked
162c7cdbf669 drm/i915: Move rate-limiting request retire to after submission
ef8df46ce628 drm/i915: Wait for engines to idle before retiring
54da9ce40510 drm/i915: Move engine request retirement to intel_engine_cs
49188298462c drm/i915: Hold request reference for submission until retirement
7315e7d0ffea drm/i915: Reduce spinlock hold time during notify_ring() interrupt
51a5b8ab6355 drm/i915: Move the irq_counter inside the spinlock
5c69384f1995 drm/i915: Only signal from interrupt when requested
2aab4afbbf22 drm/i915/execlists: Switch to rb_root_cached
b9a29659a6ef drm/i915: Reserve some priority bits for internal use
1bfc7badff94 drm/i915: Combine multiple internal plists into the same i915_priolist bucket
-:163: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name
#163: FILE: drivers/gpu/drm/i915/intel_lrc.c:367:
+	struct list_head *uninitialized_var(pl);

-:280: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name
#280: FILE: drivers/gpu/drm/i915/intel_lrc.c:1222:
+	struct list_head *uninitialized_var(pl);

-:309: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#309: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:197:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:309: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#309: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:197:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:201:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

-:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:201:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

total: 0 errors, 2 warnings, 4 checks, 271 lines checked
6783a6397aa6 drm/i915: Priority boost for new clients
0c0ac81266c0 drm/i915: Priority boost switching to an idle ring
a267a27f5ffa drm/i915: Refactor export_fence() after i915_vma_move_to_active()
7cc363d7e72e drm/i915: Export i915_request_skip()
096718df8c3c drm/i915: Start returning an error from i915_vma_move_to_active()
4ec594375095 drm/i915: Track vma activity per fence.context, not per engine
-:340: WARNING:LONG_LINE: line over 100 characters
#340: FILE: drivers/gpu/drm/i915/i915_vma.c:886:
+						       &vma->vm->i915->drm.struct_mutex)->fence.context);

total: 0 errors, 1 warnings, 0 checks, 459 lines checked
0ff6a8261332 drm/i915: Track the last-active inside the i915_vma
ec1799fc7ce1 drm/i915: Stop tracking MRU activity on VMA
8a62bfa81b1d drm/i915: Introduce i915_address_space.mutex
ec91e61d705e drm/i915: Move fence register tracking to GGTT
-:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gvt' may be better as '(gvt)' to avoid precedence issues
#23: FILE: drivers/gpu/drm/i915/gvt/gvt.h:394:
+#define gvt_fence_sz(gvt) (gvt->dev_priv->ggtt.num_fence_regs)

total: 0 errors, 0 warnings, 1 checks, 488 lines checked
8667ccbdc2c4 drm/i915: Convert fences to use a GGTT lock rather than struct_mutex
f0041cba2f5d drm/i915: Tidy i915_gem_suspend()
-:86: WARNING:TYPO_SPELLING: 'sucessfully' may be misspelled - perhaps 'successfully'?
#86: FILE: drivers/gpu/drm/i915/i915_gem.c:5093:
+	 * Assert that we sucessfully flushed all the work and

total: 0 errors, 1 warnings, 0 checks, 91 lines checked
dc7d86073dc3 drm/i915: Pull all the reset functionality together into i915_reset.c
-:1070: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1070: 
new file mode 100644

-:1075: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1075: FILE: drivers/gpu/drm/i915/i915_reset.c:1:
+/*

-:1188: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1188: FILE: drivers/gpu/drm/i915/i915_reset.c:114:
+			      unsigned engine_mask)

-:1208: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1208: FILE: drivers/gpu/drm/i915/i915_reset.c:134:
+static int i915_do_reset(struct drm_i915_private *i915, unsigned engine_mask)

-:1213: WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?
#1213: FILE: drivers/gpu/drm/i915/i915_reset.c:139:
+	/* Assert reset for at least 20 usec, and wait for acknowledgement. */

-:1235: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1235: FILE: drivers/gpu/drm/i915/i915_reset.c:161:
+static int g33_do_reset(struct drm_i915_private *i915, unsigned engine_mask)

-:1243: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1243: FILE: drivers/gpu/drm/i915/i915_reset.c:169:
+static int g4x_do_reset(struct drm_i915_private *dev_priv, unsigned engine_mask)

-:1280: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1280: FILE: drivers/gpu/drm/i915/i915_reset.c:206:
+			     unsigned engine_mask)

-:1334: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1334: FILE: drivers/gpu/drm/i915/i915_reset.c:260:
+			      unsigned engine_mask)

-:1360: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1360: FILE: drivers/gpu/drm/i915/i915_reset.c:286:
+			       unsigned engine_mask)

-:1390: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1390: FILE: drivers/gpu/drm/i915/i915_reset.c:316:
+
+

-:1420: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1420: FILE: drivers/gpu/drm/i915/i915_reset.c:346:
+			      unsigned engine_mask)

-:1445: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1445: FILE: drivers/gpu/drm/i915/i915_reset.c:371:
+typedef int (*reset_func)(struct drm_i915_private *, unsigned engine_mask);

-:1468: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1468: FILE: drivers/gpu/drm/i915/i915_reset.c:394:
+int intel_gpu_reset(struct drm_i915_private *i915, unsigned engine_mask)

-:1496: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1496: FILE: drivers/gpu/drm/i915/i915_reset.c:422:
+	for (retry = 0; retry < 3; retry++) {
+

-:1530: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "intel_get_gpu_reset"
#1530: FILE: drivers/gpu/drm/i915/i915_reset.c:456:
+	return intel_get_gpu_reset(i915) != NULL;

-:1791: WARNING:MEMORY_BARRIER: memory barrier without comment
#1791: FILE: drivers/gpu/drm/i915/i915_reset.c:717:
+	smp_mb__after_atomic();

-:2159: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects?
#2159: FILE: drivers/gpu/drm/i915/i915_reset.c:1085:
+#define i915_wedge_on_timeout(W, DEV, TIMEOUT)				\
+	for (__init_wedge((W), (DEV), (TIMEOUT), __func__);		\
+	     (W)->i915;							\
+	     __fini_wedge((W)))

-:2170: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2170: FILE: drivers/gpu/drm/i915/i915_reset.c:1096:
+	char *error_event[] = { I915_ERROR_UEVENT "=1", NULL };

-:2171: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2171: FILE: drivers/gpu/drm/i915/i915_reset.c:1097:
+	char *reset_event[] = { I915_RESET_UEVENT "=1", NULL };

-:2172: WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#2172: FILE: drivers/gpu/drm/i915/i915_reset.c:1098:
+	char *reset_done_event[] = { I915_ERROR_UEVENT "=0", NULL };

-:2181: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#2181: FILE: drivers/gpu/drm/i915/i915_reset.c:1107:
+	i915_wedge_on_timeout(&w, i915, 5*HZ) {
 	                                 ^

-:2350: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2350: FILE: drivers/gpu/drm/i915/i915_reset.h:1:
+/*

total: 0 errors, 18 warnings, 5 checks, 2799 lines checked
93c8ed5a0634 drm/i915: Remove GPU reset dependence on struct_mutex
-:509: WARNING:MEMORY_BARRIER: memory barrier without comment
#509: FILE: drivers/gpu/drm/i915/i915_reset.c:560:
+	smp_store_mb(i915->gpu_error.restart, NULL);

total: 0 errors, 1 warnings, 0 checks, 1211 lines checked

More information about the Intel-gfx mailing list