[Intel-gfx] [PATCH 1/2] drm/i915/tracepoints: Remove i915_request_execute tracepoint

Tvrtko Ursulin tursulin at ursulin.net
Mon Jun 25 17:25:45 UTC 2018


From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Long time ago execute was a fence and it made sense to have a tracepoint
corresponding to it. Nowadays it completely aligns either with request_
submit or request_in tracepoints and so is redundant.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
 drivers/gpu/drm/i915/i915_request.c |  2 --
 drivers/gpu/drm/i915/i915_trace.h   | 10 ----------
 2 files changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index e1dbb544046f..8217e19542d9 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -541,8 +541,6 @@ void __i915_request_submit(struct i915_request *request)
 	/* Transfer from per-context onto the global per-engine timeline */
 	move_to_timeline(request, &engine->timeline);
 
-	trace_i915_request_execute(request);
-
 	wake_up_all(&request->execute);
 }
 
diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index b50c6b829715..4a6a15075afa 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -685,11 +685,6 @@ DEFINE_EVENT(i915_request, i915_request_submit,
 	     TP_ARGS(rq)
 );
 
-DEFINE_EVENT(i915_request, i915_request_execute,
-	     TP_PROTO(struct i915_request *rq),
-	     TP_ARGS(rq)
-);
-
 TRACE_EVENT(i915_request_in,
 	    TP_PROTO(struct i915_request *rq, unsigned int port),
 	    TP_ARGS(rq, port),
@@ -763,11 +758,6 @@ trace_i915_request_submit(struct i915_request *rq)
 {
 }
 
-static inline void
-trace_i915_request_execute(struct i915_request *rq)
-{
-}
-
 static inline void
 trace_i915_request_in(struct i915_request *rq, unsigned int port)
 {
-- 
2.17.1



More information about the Intel-gfx mailing list