[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/ratelimit: Lockless ratelimiting
Patchwork
patchwork at emeril.freedesktop.org
Tue Jun 26 16:40:07 UTC 2018
== Series Details ==
Series: lib/ratelimit: Lockless ratelimiting
URL : https://patchwork.freedesktop.org/series/45416/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a8dce76165a9 lib/ratelimit: Lockless ratelimiting
-:74: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#74: FILE: drivers/char/random.c:947:
+ if ((unseeded_miss = atomic_xchg(&unseeded_warning.missed, 0)))
-:82: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#82: FILE: drivers/char/random.c:950:
+ if ((urandom_miss = atomic_xchg(&urandom_warning.missed, 0)))
-:173: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#173: FILE: include/linux/ratelimit.h:67:
+ if ((missed = atomic_xchg(&rs->missed, 0)))
-:195: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#195: FILE: lib/ratelimit.c:21:
+ unsigned missed = (unsigned)atomic_xchg(&rs->missed, 0);
-:195: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#195: FILE: lib/ratelimit.c:21:
+ unsigned missed = (unsigned)atomic_xchg(&rs->missed, 0);
total: 3 errors, 2 warnings, 0 checks, 186 lines checked
More information about the Intel-gfx
mailing list