[Intel-gfx] [PATCH 8/9] drm/i915/execlists: Trust the CSB

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 28 12:03:00 UTC 2018


Quoting Tvrtko Ursulin (2018-06-28 12:29:41)
> 
> On 27/06/2018 22:07, Chris Wilson wrote:
> > @@ -1881,6 +1861,7 @@ execlists_reset_prepare(struct intel_engine_cs *engine)
> >   {
> >       struct intel_engine_execlists * const execlists = &engine->execlists;
> >       struct i915_request *request, *active;
> > +     unsigned long flags;
> >   
> >       GEM_TRACE("%s\n", engine->name);
> >   
> > @@ -1902,8 +1883,9 @@ execlists_reset_prepare(struct intel_engine_cs *engine)
> >        * and avoid blaming an innocent request if the stall was due to the
> >        * preemption itself.
> >        */
> > -     if (test_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted))
> > -             process_csb(engine);
> > +     spin_lock_irqsave(&engine->timeline.lock, flags);
> > +
> > +     process_csb(engine);
> 
> I think taking the lock over process_csb belongs in the following patch.

Splitter!
-Chris


More information about the Intel-gfx mailing list