[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Third attempt at fixing the fb-helper .best_encoder() mess
Patchwork
patchwork at emeril.freedesktop.org
Thu Jun 28 13:32:44 UTC 2018
== Series Details ==
Series: drm: Third attempt at fixing the fb-helper .best_encoder() mess
URL : https://patchwork.freedesktop.org/series/45580/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f29c8d5f4a73 drm/fb-helper: Eliminate the .best_encoder() usage
4433a1a84d27 drm/i915: Nuke intel_mst_best_encoder()
a2b721972a5a drm: Add drm_connector_for_each_possible_encoder()
-:139: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'connector' - possible side-effects?
#139: FILE: include/drm/drm_connector.h:1202:
+#define drm_connector_for_each_possible_encoder(connector, encoder, __i) \
+ for ((__i) = 0; (__i) < ARRAY_SIZE((connector)->encoder_ids) && \
+ (connector)->encoder_ids[(__i)] != 0; (__i)++) \
+ for_each_if((encoder) = \
+ drm_encoder_find((connector)->dev, NULL, \
+ (connector)->encoder_ids[(__i)])) \
+
-:139: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#139: FILE: include/drm/drm_connector.h:1202:
+#define drm_connector_for_each_possible_encoder(connector, encoder, __i) \
+ for ((__i) = 0; (__i) < ARRAY_SIZE((connector)->encoder_ids) && \
+ (connector)->encoder_ids[(__i)] != 0; (__i)++) \
+ for_each_if((encoder) = \
+ drm_encoder_find((connector)->dev, NULL, \
+ (connector)->encoder_ids[(__i)])) \
+
total: 0 errors, 0 warnings, 2 checks, 99 lines checked
90693dfa299a drm/amdgpu: Use drm_connector_for_each_possible_encoder()
591478288a74 drm/nouveau: Use drm_connector_for_each_possible_encoder()
b47d629c12f3 drm/radeon: Use drm_connector_for_each_possible_encoder()
2e06ee14a7ea drm: Add drm_connector_has_possible_encoder()
-:23: WARNING:LONG_LINE_COMMENT: line over 100 characters
#23: FILE: drivers/gpu/drm/drm_connector.c:335:
+ * drm_connector_has_possible_encoder - check if the connector and encoder are assosicated with each other
total: 0 errors, 1 warnings, 0 checks, 38 lines checked
d081e0a72bd8 drm/msm: Use drm_connector_has_possible_encoder()
2dfef99446dc drm/tilcdc: Use drm_connector_has_possible_encoder()
More information about the Intel-gfx
mailing list