[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Mark up write into scratch vma
Tvrtko Ursulin
tvrtko.ursulin at linux.intel.com
Fri Jun 29 14:11:15 UTC 2018
On 29/06/2018 14:37, Chris Wilson wrote:
> We correctly attach the exclusive fetch for the scratch object when
> emitting a request that writes into it, but for completeness we should
> also declared the write to i915_vma_move_to_active()
>
> Reported-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_gem_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> index c0c26fae45c7..cc848ceeb3c3 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c
> @@ -175,7 +175,7 @@ static int gpu_fill(struct drm_i915_gem_object *obj,
> i915_vma_unpin(batch);
> i915_vma_close(batch);
>
> - i915_vma_move_to_active(vma, rq, 0);
> + i915_vma_move_to_active(vma, rq, EXEC_OBJECT_WRITE);
> i915_vma_unpin(vma);
>
> reservation_object_lock(obj->resv, NULL);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Regards,
Tvrtko
More information about the Intel-gfx
mailing list