[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc

Chris Wilson chris at chris-wilson.co.uk
Fri Jun 29 22:37:37 UTC 2018


Quoting Michał Winiarski (2018-06-18 13:32:47)
> On Mon, Jun 18, 2018 at 11:18:20AM +0000, Michal Wajdeczko wrote:
> > While debugging we may want to examine params passed to GuC.
> > 
> > v2: drop #ifdef DEBUG_GUC - Michal
> > 
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> > Reviewed-by: Michel Thierry <michel.thierry at intel.com> #1
> > Cc: Michal Winiarski <michal.winiarski at intel.com>
> 
> > ---
> >  drivers/gpu/drm/i915/intel_guc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> > index 1aff30b..feecf6e5 100644
> > --- a/drivers/gpu/drm/i915/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/intel_guc.c
> > @@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc)
> >       params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
> >       params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
> >  
> > +     for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
> > +             DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
> > +
> 
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

And pushed. Thanks for the patch and review,
-Chris


More information about the Intel-gfx mailing list