[Intel-gfx] [PATCH] drm/i915/selftests: Skip the execlists tests on !execlists machines

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri May 4 16:25:27 UTC 2018


On 04/05/2018 13:42, Chris Wilson wrote:
> Ignore the tests looking at the innards of execlists and its submission
> tasklets on machines that don't support execlists!
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/selftests/intel_lrc.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/intel_lrc.c b/drivers/gpu/drm/i915/selftests/intel_lrc.c
> index ee7e22d18ff8..b7460b5dd4f7 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_lrc.c
> @@ -505,5 +505,9 @@ int intel_execlists_live_selftests(struct drm_i915_private *i915)
>   		SUBTEST(live_preempt),
>   		SUBTEST(live_late_preempt),
>   	};
> +
> +	if (!HAS_EXECLISTS(i915))
> +		return 0;
> +
>   	return i915_subtests(tests, i915);
>   }
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Is it a mystery why it wasn't discovered when tests were added?

Regards,

Tvrtko


More information about the Intel-gfx mailing list