[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/18] drm/i915: Prepare GEM for suspend earlier

Patchwork patchwork at emeril.freedesktop.org
Fri May 25 09:55:17 UTC 2018


== Series Details ==

Series: series starting with [01/18] drm/i915: Prepare GEM for suspend earlier
URL   : https://patchwork.freedesktop.org/series/43765/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f6ebcbc1316a drm/i915: Prepare GEM for suspend earlier
14c41b87a902 drm/i915: Switch to kernel context before idling at runtime
5523a66842f6 drm/i915: "Race-to-idle" after switching to the kernel context
a18c5ca5e1be drm/i915: After reset on sanitization, reset the engine backends
13da5d1a87bb drm/i915: Only sanitize GEM from late suspend
6f2dabddf373 drm/i915: Flush the ring stop bit after clearing RING_HEAD in reset
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
<7>[  239.094843] i915_gem_set_wedged 	current seqno 19a98, last 19a9a, hangcheck 0 [5158 ms]

total: 0 errors, 1 warnings, 0 checks, 40 lines checked
add445ce0814 drm/i915: Be irqsafe inside reset
6ee85e893f58 drm/i915/execlists: Wait for ELSP submission on restart
-:53: WARNING:TYPO_SPELLING: 'mutiple' may be misspelled - perhaps 'multiple'?
#53: FILE: drivers/gpu/drm/i915/intel_lrc.c:2018:
+	 * serialising mutiple attempts to reset so that we know that we

total: 0 errors, 1 warnings, 0 checks, 37 lines checked
7d22a392f8d1 drm/i915/execlists: Reset the CSB head tracking on reset/sanitization
-:41: WARNING:LONG_LINE: line over 100 characters
#41: FILE: drivers/gpu/drm/i915/intel_lrc.c:979:
+				(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_BUF_LO(engine, 0)));

total: 0 errors, 1 warnings, 0 checks, 52 lines checked
f00e2ca10476 drm/i915/execlists: Pull submit after dequeue under timeline lock
4474beaad02f drm/i915/execlists: Pull CSB reset under the timeline.lock
a1159c99f645 drm/i915/execlists: Process one CSB interrupt at a time
-:35: WARNING:MEMORY_BARRIER: memory barrier without comment
#35: FILE: drivers/gpu/drm/i915/intel_lrc.c:966:
+	smp_mb__after_atomic();

-:77: WARNING:LONG_LINE: line over 100 characters
#77: FILE: drivers/gpu/drm/i915/intel_lrc.c:990:
+		  head, GEN8_CSB_READ_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?",

-:78: WARNING:LONG_LINE: line over 100 characters
#78: FILE: drivers/gpu/drm/i915/intel_lrc.c:991:
+		  tail, GEN8_CSB_WRITE_PTR(readl(i915->regs + i915_mmio_reg_offset(RING_CONTEXT_STATUS_PTR(engine)))), fw ? "" : "?");

-:140: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#140: FILE: drivers/gpu/drm/i915/intel_lrc.c:1022:
+			  status, buf[2*head + 1],
 			               ^

-:176: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#176: FILE: drivers/gpu/drm/i915/intel_lrc.c:1040:
+		    buf[2*head + 1] == execlists->preempt_complete_status) {
 		         ^

total: 0 errors, 3 warnings, 2 checks, 301 lines checked
ce11b28a15fa drm/i915/execlists: Unify CSB access pointers
1d85b2b170a0 drm/i915/execlists: Direct submission of new requests (avoid tasklet/ksoftirqd)
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
Comparing the impact on the maximum latency observed (that is the time stolen

-:100: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")'
#100: 
References: 27af5eea54d1 ("drm/i915: Move execlists irq handler to a bottom half")

total: 1 errors, 1 warnings, 0 checks, 358 lines checked
5f5f78da7433 drm/i915: Move rate-limiting request retire to after submission
44f2b6d34b54 drm/i915: Wait for engines to idle before retiring
408446da1803 drm/i915: Move engine request retirement to intel_engine_cs
66703c7b803c drm/i915: Hold request reference for submission until retirement



More information about the Intel-gfx mailing list