[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Fix sprite destination colorkeying on SKL+

Patchwork patchwork at emeril.freedesktop.org
Tue May 29 18:34:21 UTC 2018


== Series Details ==

Series: series starting with [1/5] drm/i915: Fix sprite destination colorkeying on SKL+
URL   : https://patchwork.freedesktop.org/series/43902/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ab49b9e98274 drm/i915: Fix sprite destination colorkeying on SKL+
b08400aa9188 drm/i915: Fix VLV/CHV sprite src colorkey mask
c99414ba31cf drm/i915: Add basic immutable zpos properties for all planes
0a5bc4c8cb26 drm/i915: Make primary/sprite zpos configurable on VLV/CHV
-:90: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#90: FILE: drivers/gpu/drm/i915/i915_reg.h:6268:
+#define   SP_BOTTOM			(1<<2)
                    			  ^

-:91: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#91: FILE: drivers/gpu/drm/i915/i915_reg.h:6269:
+#define   SP_ZORDER			(1<<0)
                    			  ^

-:336: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#336: FILE: drivers/gpu/drm/i915/intel_display.h:336:
+#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->base.dev->mode_config.num_crtc && \
+		     ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \
+		      (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \
+		      (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \
+	     (__i)++) \
+		for_each_if(crtc)

-:336: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects?
#336: FILE: drivers/gpu/drm/i915/intel_display.h:336:
+#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->base.dev->mode_config.num_crtc && \
+		     ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \
+		      (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \
+		      (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \
+	     (__i)++) \
+		for_each_if(crtc)

-:336: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#336: FILE: drivers/gpu/drm/i915/intel_display.h:336:
+#define for_each_oldnew_intel_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \
+	for ((__i) = 0; \
+	     (__i) < (__state)->base.dev->mode_config.num_crtc && \
+		     ((crtc) = to_intel_crtc((__state)->base.crtcs[__i].ptr), \
+		      (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \
+		      (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \
+	     (__i)++) \
+		for_each_if(crtc)

-:340: WARNING:LONG_LINE: line over 100 characters
#340: FILE: drivers/gpu/drm/i915/intel_display.h:340:
+		      (old_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].old_state), \

-:341: WARNING:LONG_LINE: line over 100 characters
#341: FILE: drivers/gpu/drm/i915/intel_display.h:341:
+		      (new_crtc_state) = to_intel_crtc_state((__state)->base.crtcs[__i].new_state), 1); \

total: 0 errors, 2 warnings, 5 checks, 299 lines checked
c844de7ddf13 drm/i915: Implement dst colorkeying for VLV/CHV sprites
-:31: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#31: FILE: drivers/gpu/drm/i915/i915_reg.h:6003:
+#define   DISPPLANE_SRC_KEY_WINDOW_ENABLE	(1<<23) /* planes A/B */
                                          	  ^

total: 0 errors, 0 warnings, 1 checks, 259 lines checked



More information about the Intel-gfx mailing list